Repository navigation
fix: outline the selected row only on keyboard focus - #150
Merged
Merged
Conversation
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes Reviewed the selected-row focus styling and its browser regression coverage.
- Keyboard-only outline: Replaces the always-focused left marker with a rounded inset outline gated by the listbox’s
:focus-visible, preserving the selection background and existing container fallback. - Interaction coverage: Updates outline assertions and verifies that pointer clicks suppress the outline while subsequent keyboard navigation restores it.
Validation: all 34 Chromium keyboard-navigation tests passed. The test server also completed TypeScript checking and the production build. Other browsers were not tested.
gpt-6.1-sol ｜ 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the orange left bar, shown on every click, with a rounded outline that appears only on keyboard focus.